8000 adding initial redis output support by dvas0004 · Pull Request #45 · cea-sec/openwec · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

adding initial redis output support #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2023
Merged

adding initial redis output support #45

merged 7 commits into from
Sep 29, 2023

Conversation

dvas0004
Copy link
Contributor

Adding initial support for a "redis list" output. Tested and working fine on ubuntu 22 LTS

Documentation reproduced below for your convenience as it pretty much sums it up

Redis

This output type sends events to a Redis list using the LPUSH command

You must provide:

  • a redis server address containing the IP and port to connect to.
  • a list name

TODO:

  • implement TLS connections to redis
  • support redis auth
  • ...

Examples

  • Send events to a redis server into a list named "wec":
$ openwec subscriptions edit my-test-subscription outputs add --format <format> redis 127.0.0.1:6377 wec

@vruello
Copy link
Contributor
vruello commented Sep 29, 2023

Thank you for this nice contribution 👍

I see that you updated the PR this morning, is it ready to be reviewed? Do you plan to implement the TODOs you wrote now or do you prefer the initial support to be merged before?

@dvas0004
Copy link
Contributor Author

hey @vruello !!

to be honest i would go ahead and review it, the TODOs will come but at the moment they are "nice to haves" and the system is already working very well without them

vruello
vruello requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor
@vruello vruello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions for improvement! Btw, I really appreciate your efforts to document the output usage 👍

Could you add the feature in CHANGELOG.md?

@dvas0004
Copy link
Contributor Author

thank you very much for your feedback @vruello !! i just committed your feedback👍

vruello
vruello reviewed Sep 29, 2023
View reviewed changes
@vruello vruello merged commit 8cb71d2 into cea-sec:main Sep 29, 2023
@vruello
Copy link
Contributor
vruello commented Sep 29, 2023

Once again, thank you very much for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vruello vruello vruello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvas0004 @vruello
0