8000 Fix/disconnect by nicolasbrugneaux · Pull Request #225 · celo-org/react-celo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

Fix/disconnect #225

Merged
merged 4 commits into from
May 25, 2022
Merged

Fix/disconnect #225

merged 4 commits into from
May 25, 2022

Conversation

nicolasbrugneaux
Copy link
Contributor
@nicolasbrugneaux nicolasbrugneaux commented May 25, 2022

Fix #222
Fix #165

Fix regression from #212 (qr code was not appearing for mobile-only connectors)

Adds a new retry button when the walletconnect connection is denied from the wallet (initial connection)

@vercel
Copy link
vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
use-contractkit ✅ Ready (Inspect) Visit Preview May 25, 2022 at 4:04PM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #225 (007c4ad) into master (8b0b225) will decrease coverage by 0.61%.
The diff coverage is 8.69%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   60.44%   59.83%   -0.62%     
==========================================
  Files          51       51              
  Lines        1398     1414      +16     
  Branches      194      199       +5     
==========================================
+ Hits          845      846       +1     
- Misses        405      415      +10     
- Partials      148      153       +5     
Impacted Files Coverage Δ
packages/react-celo/src/connectors/connectors.ts 61.06% <0.00%> (-1.67%) ⬇️
packages/walletconnect-v1/src/types.ts 86.66% <ø> (ø)
...t-celo/src/connectors/useWalletConnectConnector.ts 13.33% <8.33%> (-2.46%) ⬇️
packages/react-celo/src/screens/wallet-connect.tsx 34.21% <20.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0b225...007c4ad. Read the comment docs.

@dckesler dckesler merged commit c2846c7 into master May 25, 2022
@dckesler dckesler deleted the fix/disconnect branch May 25, 2022 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnecting from Valora's side doesn't update dapp Cancelling a connection request from the wallet should directly close QR code and show feedback
3 participants
0