8000 Allow celo SDK v2 or v3 for `@celo/wallet-walletconnect` by jeanregisser · Pull Request #347 · celo-org/react-celo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

Allow celo SDK v2 or v3 for @celo/wallet-walletconnect #347

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Allow celo SDK v2 or v3 for @celo/wallet-walletconnect #347

merged 3 commits into from
Feb 24, 2023

Conversation

jeanregisser
Copy link
Contributor
@jeanregisser jeanregisser commented Feb 24, 2023 •
edited
Loading

I noticed @celo/wallet-walletconnect@5.0.2 pulled by @celo/react-celo@5.0.2 depends on celo SDK ^2.2.0 leading to duplicate packages in the final bundle if celo SDK v3 is already present.

"@celo/wallet-walletconnect@5.0.2":
  version "5.0.2"
  resolved "https://registry.yarnpkg.com/@celo/wallet-walletconnect/-/wallet-walletconnect-5.0.2.tgz#14d8fff7c232578977878f2ea2c552fe5df06b70"
  integrity sha512-CK6hGfYgrqC9iHAJvauofs9U3RdEqIZ16fm/95fgso0OMe1i8Gn9v/TNPpM2cuIY9/58zZshgHKqCAODzH8ukg==
  dependencies:
    "@celo/connect" "^2.2.0"
    "@celo/utils" "^2.2.0"
    "@celo/wallet-base" "^2.2.0"
    "@celo/wallet-remote" "^2.2.0"
    "@walletconnect/auth-client" "^2.0.2"
    "@walletconnect/sign-client" "^2.3.2"
    "@walletconnect/types" "^2.3.2"
    "@walletconnect/utils" "^2.3.2"
    debug "^4.3.3"
    ethereumjs-util "^7.1.3"

This applies a similar change to what was done for @celo/react-celo in #339

Let me know what you think.

Side note: I wonder if celo SDK dependencies should be switched to peerDependencies to make it easier for final applications to select the version they want.

@vercel
Copy link
vercel bot commented Feb 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-celo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 5:52PM (UTC)

@nicolasbrugneaux nicolasbrugneaux force-pushed the jeanregisser/celo-sdk-bump branch from f81920b to 24fe949 Compare February 24, 2023 17:48
@nicolasbrugneaux nicolasbrugneaux merged commit df85f0e into master Feb 24, 2023
@nicolasbrugneaux nicolasbrugneaux deleted the jeanregisser/celo-sdk-bump branch February 24, 2023 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolasbrugneaux nicolasbrugneaux nicolasbrugneaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanregisser @nicolasbrugneaux
0