8000 feat: support for EC keys in JWK sets and EC JWTs when using JWKS by shaunco · Pull Request #720 · centrifugal/centrifugo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support for EC keys in JWK sets and EC JWTs when using JWKS #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2023
Merged

feat: support for EC keys in JWK sets and EC JWTs when using JWKS #720

merged 2 commits into from
Oct 6, 2023

Conversation

shaunco
Copy link
Contributor
@shaunco shaunco commented Oct 4, 2023

test: new JWKS tests for RSA and EC
Fixes #719

8000
@FZambia FZambia self-requested a review October 5, 2023 12:23
FZambia
FZambia approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member
@FZambia FZambia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, great addition, and special 👍 for tests.

Looking at your commit message starting with fix: - it seems you still think it's a bug 😈 😀

@shaunco shaunco changed the title fix: support for EC keys in JWK sets and EC JWTs when using JWKS feat: support for EC keys in JWK sets and EC JWTs when using JWKS Oct 5, 2023
@shaunco
Copy link
Contributor Author
shaunco commented Oct 5, 2023

Fixed the PR title (😅) and moved that final return statement. I assume you will squash merge rather than wanting me to force push that last change, but let me know if I have that wrong.

@FZambia FZambia merged commit 0153da4 into centrifugal:master Oct 6, 2023
@FZambia
Copy link
Member
FZambia commented Oct 6, 2023

Thanks a lot, this is great!

@shaunco
Copy link
Contributor Author
shaunco commented Oct 7, 2023

@FZambia - Thanks for getting this in! If you have a moment, a v5.0.5 release would be much appreciated!

@FZambia
Copy link
Member

@shaunco , Centrifugo is usually released not often than once in 3-4 weeks, except bug fix releases. Most probably v5.0.5 will be released till the end of this week - requires some time to prepare.

@shaunco
Copy link
Contributor Author
shaunco commented Oct 9, 2023

Thanks, I'll keep an eye out for it. We can't make use of it until the EC JWKS change is in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FZambia FZambia FZambia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] JWKS should not be limited to RSA
2 participants
@shaunco @FZambia
0