8000 bump rueidis to 1.0.22 to fix 32-bit systems by tie · Pull Request #737 · centrifugal/centrifugo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bump rueidis to 1.0.22 to fix 32-bit systems #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bump rueidis to 1.0.22 to fix 32-bit systems #737

wants to merge 1 commit into from

Conversation

tie
Copy link
Contributor
@tie tie commented Nov 24, 2023

Proposed changes

This is a small change that updates github.com/redis/rueidis from v1.0.21 to v1.0.22 that contains a fix for atomics on 32-bit systems (see redis/rueidis#408).

For context, I’m maintaining Centrifugo package in NixOS/Nixpkgs that was recently merged and will be available in 23.11 release. Part of the NixOS release process is the Zero Hydra Failures Project (Hydra is a CI system used in Nix ecosystem), a campaign that aims to reduce the number of failing jobs. We have a simple integration test for Centrifugo that is failing on i686-linux, see https://hydra.nixos.org/build/242072250/nixlog/1.

I’d like to avoid backporting this change by patching the source code, and since there were no major changes since the last release, I’d appreciate if you can create v5.1.2.

@FZambia
Copy link
Member
FZambia commented Nov 25, 2023

Hello @tie

Thanks! I fixed this in centrifugal/centrifuge@9476a84 - i.e. in the lib Centrifugo is built on top of. So this fix will be part of v5.1.2

@FZambia FZambia closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tie @FZambia
0