8000 enhancement: Make `--verbose` less noisy in combination with `--run` by haines · Pull Request #2351 · cerbos/cerbos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

enhancement: Make --verbose less noisy in combination with --run #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

haines
Copy link
Member
@haines haines commented Oct 18, 2024

If you have a large test suite and you run into failures that you want to debug with traces, running that specific test with --run and specifying --verbose gives you the traces, but also gives you a massive tree showing all the tests that were skipped because they didn't match the pattern you provided.

Taking a leaf out of go test -run's book, this PR hides the tests that were skipped because they didn't match the pattern.

As a bonus, this means that the skipReason set on test suites or individual tests is now propagated to the test results, which means that we can start displaying it in Hub.

I've also fixed an error in the logic for filtering tests when policies have been excluded from a bundle.

@haines haines added kind/enhancement New feature or request area/testing labels Oct 18, 2024
@haines haines marked this pull request as ready for review October 18, 2024 08:41
@haines haines requested a review from charithe October 18, 2024 08:41
…d policies

Signed-off-by: Andrew Haines <haines@cerbos.dev>
Signed-off-by: Andrew Haines <haines@cerbos.dev>
@haines haines merged commit 018340b into cerbos:main Oct 18, 2024
22 checks passed
@haines haines deleted the quieter-run branch October 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0