feat: Define constants for use in condition expressions #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Haines <haines@cerbos.dev>
This was referenced Nov 1, 2024
charithe
approved these changes
Nov 4, 2024
haines
added a commit
to cerbos/cerbos-sdk-go
that referenced
this pull request
Nov 4, 2024
cerbos/cerbos#2364 Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
added a commit
that referenced
this pull request
Nov 4, 2024
#2364 cerbos/cerbos-sdk-go#83 --------- Signed-off-by: Andrew Haines <haines@cerbos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
constants(C) top-level identifier in CEL expressions, aconstantssection to define the values, and anexportConstantspolicy type to share definitions between policies.Constants are an alternative to defining variables with literal values, which avoids the need to quote values as CEL expressions by allowing them to be defined with standard YAML/JSON syntax.
It also fixes a few bugs in the policy inspection logic so that resource attributes and variables are discovered transitively for all policy types.