8000 enhancement(plan): Query plan scope permissions support for resource and principal policies by dbuduev · Pull Request #2361 · cerbos/cerbos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

enhancement(plan): Query plan scope permissions support for resource and principal policies #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 1, 2024
Merged

enhancement(plan): Query plan scope permissions support for resource and principal policies #2361

merged 21 commits into from
Nov 1, 2024

Conversation

dbuduev
Copy link
Contributor
@dbuduev dbuduev commented Oct 29, 2024

No description provided.

dbuduev and others added 13 commits October 25, 2024 13:54
@dbuduev
resource policy wip
8309f73 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
WIP
d762df4 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
bugfix
e495492 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
WIP
efdcb49 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
WIP
1d43040 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
test passed
d3ed973 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
linter
3751ef4 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
DENY test
e06329a 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
bugfix
59eb926 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
Merge branch 'main' into feat/planner-fall-through-on-allow
c25f78e
@dbuduev
fix scope
2df1b2d 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
fix scopes
fad7a83 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
default scopePermissions is incorrect for precompiled bundles
491feec 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev dbuduev marked this pull request as ready for review October 30, 2024 03:56
@dbuduev dbuduev requested a review from charithe October 30, 2024 03:57
@charithe charithe requested a review from Sambigeara October 30, 2024 08:48
@charithe charithe changed the title feat(plan): Fall-through behaviour in resource and principal policies enhancement(plan): Query plan scope permissions support Oct 30, 2024
@dbuduev dbuduev enabled auto-merge (squash) October 30, 2024 09:48
charithe
charithe reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor
@charithe charithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would just like to double check with @Sambigeara in case I'd forgotten something about the original implementation.

@Sambigeara
Copy link
Contributor

Apologies, I'll take a look at this properly tomorrow morning when my brain's less fried!

@Sambigeara Sambigeara changed the title enhancement(plan): Query plan scope permissions support enhancement(plan): Query plan scope permissions support for resource and principal policies Oct 31, 2024
Sambigeara
Sambigeara reviewed Oct 31, 2024
View reviewed changes
@dbuduev
feedback
0730a8d 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
rename
3247572 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev dbuduev marked this pull request as draft October 31, 2024 11:08
auto-merge was automatically disabled October 31, 2024 11:08

Pull request was converted to draft

@dbuduev dbuduev marked this pull request as ready for review October 31, 2024 11:08
@dbuduev
add failing test
cf8f730 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
comment
59a8c73 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
comment out fmt.Print< 8000 /a>
0db06f1 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
Sambigeara
Sambigeara previously approved these changes Nov 1, 2024
View reviewed changes
@dbuduev
clean up
56f32be 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
update a test case
9b9bf00 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
Copy link
Contributor Author
dbuduev commented Nov 1, 2024

@Sambigeara, please give it another look, as your review was removed after I updated a test case.

@dbuduev dbuduev enabled auto-merge (squash) November 1, 2024 09:17
@dbuduev dbuduev merged commit a5b7f8e into cerbos:main Nov 1, 2024
22 checks passed
7C4D
@dbuduev dbuduev deleted the feat/planner-fall-through-on-allow branch November 1, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charithe charithe charithe left review comments

@Sambigeara Sambigeara Sambigeara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbuduev @Sambigeara @charithe
0