fix: Reload rule table when store contents change #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs a proper unit test that I'll add in a different PR. In the mean time, this should fix the E2E test failures. Fixes cerbos#2451 Signed-off-by: Charith Ellawala <charith@cerbos.dev>
haines
approved these changes
Jan 17, 2025
Sambigeara
reviewed
Jan 20, 2025
Comment on lines
+175
to
+176
| if ss, ok := policyLoader.(storage.Subscribable); ok { | ||
| ss.Subscribe(rt) |
There was a problem hiding this comment.
I'm not sure I understand why this is the case. For mutable stores, the original stores remain as the source of truth, and a "partial rule table" is generated at query time (and discarded afterwards).
In the mutable-store case, partial rule tables are (currently) generated from the mutable store per-query and discarded afterwards. I chose to do this as an initial step as it seemed odd to maintain two sources of mutable truth.
This may or may not be related to the recent E2E test failure (it's currently nil-pointering on a nonexistent policy set passed to the addPolicy method).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a proper unit test that I'll add in a different PR. In the
mean time, this should fix the E2E test failures (or uncover more issues).
Fixes #2451
Signed-off-by: Charith Ellawala charith@cerbos.dev