8000 chore: Add tests for resource policy with REQUIRE_PARENTAL_CONSENT_FOR_ALLOWS by dbuduev · Pull Request #2466 · cerbos/cerbos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Add tests for resource policy with REQUIRE_PARENTAL_CONSENT_FOR_ALLOWS #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 19, 2025
Merged

chore: Add tests for resource policy with REQUIRE_PARENTAL_CONSENT_FOR_ALLOWS #2466

merged 14 commits into from
Feb 19, 2025

Conversation

dbuduev
Copy link
Contributor
@dbuduev dbuduev commented Feb 5, 2025 •
edited
Loading

A few test cases for resource policies having "REQUIRE_PARENTAL_CONSENT_FOR_ALLOWS" scope permissions:

  • case 29 mirrors case 26, which covers principal policies.
  • case 30 shows that if a principal has multiple roles, a policy without reference to a role can be ignored.

Both test cases are supported by new policies: "policy_17.acme.yaml" and "policy_17.acme.sales.yaml".

@dbuduev
create
5b6956c 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
complete case_29
42a070e 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
WIP
36ba564 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
case_30
f135bfb 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
update case_30
facdc72 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
clean-up
ff6b619 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
acme_action case_30
1a7cb7e 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
update test
9bbc6a6 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev dbuduev marked this pull request as ready for review February 5, 2025 04:15
@dbuduev dbuduev requested a review from Sambigeara February 5, 2025 04:16
dbuduev and others added 2 commits February 18, 2025 07:01
@dbuduev
Merge branch 'main' into chore/new-tests-for-resource-policies
c570c1b
@dbuduev
update test cases
9e6ac5a 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev dbuduev enabled auto-merge (squash) February 18, 2025 08:45
Sambigeara
Sambigeara reviewed Feb 18, 2025
View reviewed changes
dbuduev and others added 4 commits February 19, 2025 10:55
@dbuduev @Sambigeara
Update internal/test/testdata/engine/case_29.yaml
e4b3522 
Co-authored-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: dbuduev <dennis@cerbos.dev>
@dbuduev
incorporate PR feedback
0be74bf 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
incorporate PR feedback
b306e1e 
Signed-off-by: Dennis Buduev <dbuduev@users.noreply.github.com>
@dbuduev
Merge branch 'main' into chore/new-tests-for-resource-policies
a90dc7e
@dbuduev dbuduev merged commit ba523cd into main Feb 19, 2025
22 checks passed
@dbuduev dbuduev deleted the chore/new-tests-for-resource-policies branch February 19, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sambigeara Sambigeara Sambigeara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbuduev @Sambigeara
0