8000 Link ingress-shim into main controller binary by munnerz · Pull Request #502 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Link ingress-shim into main controller binary #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2018
Merged

Link ingress-shim into main controller binary #502

merged 8 commits into from
Apr 26, 2018

Conversation

munnerz
Copy link
Member
@munnerz munnerz commented Apr 23, 2018 •
edited
Loading

What this PR does / why we need it:

Removes the standalone ingress-shim binary and instead links it cert-manager-controller itself.

This will reduce the overall memory footprint of cert-manager and simplify deployment.

Special notes for your reviewer:

This still needs helm chart and docs updates

Release note:

Remove ingress-shim and link it into cert-manager itself ACTION REQUIRED: You must change your 'helm install' command to use the new --ingressShim.defaultIssuerName, --ingressShim.defaultIssuerKind options when upgrading as --ingressShim.extraArgs has been removed.

@munnerz munnerz self-assigned this Apr 23, 2018
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2018
@jetstack-bot jetstack-bot requested a review from kragniz April 23, 2018 12:29
@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2018
@munnerz munnerz changed the title WIP: Link ingress-shim into main controller binary Link ingress-shim into main controller binary Apr 23, 2018
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2018
@munnerz munnerz force-pushed the integrate-ingress-shim branch from 87966ea to e924bf9 Compare April 23, 2018 15:17
@jetstack-bot jetstack-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 24, 2018
kragniz
kragniz approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor
@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@munnerz munnerz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 26, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@munnerz munnerz force-pushed the integrate-ingress-shim branch from 6018397 to 31fb8aa Compare April 26, 2018 11:44
@jetstack-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2018
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2018
@munnerz
Copy link
Member Author
munnerz commented Apr 26, 2018

Rebased after #493 merged

@jetstack-bot jetstack-bot merged commit 62c2fd8 into cert-manager:master Apr 26, 2018
@munnerz munnerz mentioned this pull request May 2, 2018
Merged
munnerz added a commit to munnerz/charts-1 that referenced this pull request May 24, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e
4c04b32 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
@munnerz munnerz mentioned this pull request May 24, 2018
Merged
k8s-ci-robot pushed a commit to helm/charts that referenced this pull request May 24, 2018
@munnerz @k8s-ci-robot
cert-manager: fast-forward to upstream 1e606b3e (#5744)
cc8e3fd 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
cesaralbloz pushed a commit to cesaralbloz/charts that referenced this pull request May 25, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
ff48906 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
@munnerz @or1can
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
f416fe8 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
aa3bc39 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)

Signed-off-by: voron <av@arilot.com>
@munnerz munnerz deleted the integrate-ingress-shim branch January 29, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz kragniz approved these changes

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munnerz @jetstack-bot @kragniz
0