8000 Add solverFor and wait.go unit tests for acme dns solver by munnerz · Pull Request #185 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add solverFor and wait.go unit tests for acme dns solver #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2017
Merged

Add solverFor and wait.go unit tests for acme dns solver #185

merged 1 commit into from
Nov 4, 2017

Conversation

munnerz
Copy link
Member
@munnerz munnerz commented Nov 3, 2017

What this PR does / why we need it:

Adds some unit tests for ACME dns solver

Release note:

NONE

@munnerz munnerz self-assigned this Nov 3, 2017
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2017
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2017
@munnerz
Copy link
Member Author
munnerz commented Nov 4, 2017

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2017
@jetstack-bot
Copy link
Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@jetstack-bot jetstack-bot merged commit 91c543c into cert-manager:master Nov 4, 2017
@munnerz munnerz added this to the v0.2 milestone Nov 4, 2017
@munnerz munnerz mentioned this pull request Nov 4, 2017
Merged
jetstack-bot added a commit that referenced this pull request Nov 4, 2017
@jetstack-bot
Merge pull request #190 from munnerz/automated-cherry-pick-of-#185-up…
83a6e13 
…stream-release-0.2

Automatic merge from submit-queue.

Automated cherry pick of #185

Cherry pick of #185 on release-0.2.

#185: Add solverFor and wait.go unit tests for acme dns solver

```release-note
NONE
```
@jetstack-bot
Copy link
Contributor

Commit found in the "release-0.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@munnerz munnerz deleted the dns-unit-tests branch January 29, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@munnerz @jetstack-bot
0