8000 [release-0.15] Error on venafi CertificateRequest when DN is empty by jetstack-bot · Pull Request #3054 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[release-0.15] Error on venafi CertificateRequest when DN is empty #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2020
Merged

[release-0.15] Error on venafi CertificateRequest when DN is empty #3054

merged 3 commits into from
Jul 1, 2020

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #3053

/assign meyskens

Error on venafi CertificateRequest when DN is empty

meyskens added 3 commits July 1, 2020 15:29
@meyskens
Error on venafi CertificateRequest when DN is empty
57b8c66 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Implement feedback on error message
8eaf3f0 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Add unit test
3276b1c 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot jetstack-bot added this to the v0.15 milestone Jul 1, 2020
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 1, 2020
@jetstack-bot jetstack-bot mentioned this pull request Jul 1, 2020
Merged
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 1, 2020
@jetstack-bot jetstack-bot requested a review from munnerz July 1, 2020 15:29
@jetstack-bot jetstack-bot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2020
@meyskens
Copy link
Contributor
meyskens commented Jul 1, 2020

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@meyskens
Copy link
Contributor
meyskens commented Jul 1, 2020

/approve

@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, meyskens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@meyskens meyskens added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 1, 2020
@meyskens
Copy link
Contributor
meyskens commented Jul 1, 2020

/kind bug

1 similar comment
@meyskens
Copy link
Contributor
meyskens commented Jul 1, 2020

/kind bug

@meyskens meyskens added the kind/bug Categorizes issue or PR as related to a bug. label Jul 1, 2020
@jetstack-bot jetstack-bot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 1, 2020
@jetstack-bot jetstack-bot merged commit ce9d9c1 into cert-manager:release-0.15 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@meyskens meyskens

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@jetstack-bot @meyskens
0