Support v1 admission webhooks #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
meyskens
commented
Aug 10, 2020
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/klog/klogr" | ||
|
|
||
| "github.com/jetstack/cert-manager/pkg/internal/api/validation" | ||
| "github.com/jetstack/cert-manager/pkg/webhook/handlers/testdata/apis/testgroup/install" | ||
| "github.com/jetstack/cert-manager/pkg/webhook/handlers/testdata/apis/testgroup/v1" | ||
| "github.com/jetstack/cert-manager/pkg/webhook/handlers/testdata/apis/testgroup/v2" | ||
| v1 "github.com/jetstack/cert-manager/pkg/webhook/handlers/testdata/apis/testgroup/v1" |
There was a problem hiding this comment.
Not entirely sure why goimports did this...
|
/test pull-cert-manager-e2e-v1-15 |
james-w
reviewed
Aug 10, 2020
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
|
/lgtm |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds support for admissionregistration.k8s.io/v1. Both in deployment and webhook server.
It will be the default version in the normal manifests, the legacy version will use v1beta1.
All code paths are changed to be v1, if v1beta1 is sent it will convert it to v1 and back to v1beta1 in response, this is done to keep supporting the legacy versions while being ready for v1beta1 being removed in future releases of Kubernetes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #2952
Release note:
/kind cleanup