Fix decode strategy when splitting a chunk #3

arthurstomp · 2025-02-13T20:33:47Z

This PR 8000 fixes the remainig failing test in CI.

The encode function creates its 2x bytes output by merging 2 vectors of x bytes intercalating the values by if the index is even or odd. However, in the decode function splits the same 2 x bytes vector by just cutting it in half. That difference in strategy on splitting those larger vector seems to be the cause of the failing test.

This PR adds new function nibble_chunk that splits a larger vector in 2 smaller vectors using the even/odd strategy from the encode function.

arthurstomp · 2025-02-13T20:49:10Z

@cfcosta, is this failure of the build being caused by a formatting issue?

Below is the log i get from nix-store when i try nix flake check.

WARN no formatter for path: LICENSE-APACHE
traversed 4 files
emitted 2 files for processing
formatted 2 files (0 changed) in 24ms
2025/02/13 20:43:58 INFO using config file: /nix/store/rpyryr563jjm9li5x8avljprd4haqpkm-treefmt.toml
ERRO file has changed path=src/lib.rs prev_size=7139 prev_mod_time="1970-01-01 00:00:01 +0000 UTC" current_size=7141 current_mod_time="2025-02-13 20:43:58 +0000 UTC"
traversed 1 files
emitted 1 files for processing
formatted 1 files (1 changed) in 30ms
Error: unexpected changes detected, --fail-on-change is enabled

diff --git a/src/lib.rs b/src/lib.rs
index c74f202..264fbe1 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -145,19 +145,18 @@ fn decode_hex_nibble(n: u8x16) -> Result<u8x16, Error> {
 #[inline]
 fn nibble_chunck(chunk: &[u8]) -> (u8x16, u8x16) {
     let parsed_chunk = u8x32::from_slice(chunk);
-    let mut high_bytes_vec: Vec<u8> = vec![];
-    let mut low_bytes_vec: Vec<u8> = vec![];
-    for (index,piece) in parsed_chunk.to_array().iter().enumerate() {
+    let mut high_bytes_vec: Vec<u8> = vec![];
+    let mut low_bytes_vec: Vec<u8> = vec![];
+    for (index, piece) in parsed_chunk.to_array().iter().enumerate() {
         if index % 2 == 0 {
             high_bytes_vec.push(piece.clone())
         } else {
             low_bytes_vec.push(piece.clone())
         }
-
     }
     (
-      u8x16::from_slice(&high_bytes_vec),
-      u8x16::from_slice(&low_bytes_vec),
+        u8x16::from_slice(&high_bytes_vec),
+        u8x16::from_slice(&low_bytes_vec),
     )
 }

arthurstomp · 2025-02-13T20:50:32Z

Test are passing, though

cfcosta

very nice! just a little nitpicks.

cfcosta · 2025-02-19T16:53:02Z

src/lib.rs

@@ -142,6 +142,22 @@ fn decode_hex_nibble(n: u8x16) -> Result<u8x16, Error> {
    Ok(result)
 }

+#[inline]
+fn nibble_chunck(chunk: &[u8]) -> (u8x16, u8x16) {


nibble_chunk

cfcosta · 2025-02-19T16:54:49Z

src/lib.rs

+#[inline]
+fn nibble_chunck(chunk: &[u8]) -> (u8x16, u8x16) {
+    let parsed_chunk = u8x32::from_slice(chunk);
+    let mut high_bytes_vec: Vec<u8> = vec![]; 


Instead of using vec to allocate on the heap, can we just set [u8; X] directly? that way we don't need to allocate memory.

fix: use even/odd strategy to split chunk on decode

8a1fee9

cfcosta requested changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix decode strategy when splitting a chunk #3

Fix decode strategy when splitting a chunk #3

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix decode strategy when splitting a chunk #3

Are you sure you want to change the base?

Fix decode strategy when splitting a chunk #3

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!