8000 Initial fix for Allegro CL 11 by dieggsy · Pull Request #398 · cffi/cffi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial fix for Allegro CL 11 #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Initial fix for Allegro CL 11 #398

merged 1 commit into from
Mar 11, 2025

Conversation

dieggsy
Copy link
@dieggsy dieggsy commented Oct 28, 2024 •
edited
Loading

The internal system::ff-funcall function was renamed to system::ff_funcall. This gets us most of the way there, but there are still issues with vararg functions.

There are still some outstanding issues (tests that fail in 11 but not in 10), but this seems better than nothing for now.

@dieggsy
Copy link
Author
dieggsy commented Mar 6, 2025

I have rebased this over current master. Are there any roadblocks for this currently?

@dieggsy
Copy link
Author
dieggsy commented Mar 6, 2025

I should note that while this doesn't 100% fix foreign-funcall, it does make CFFI usable at all on ACL 11. I do think further fixes can be made separately.

@dieggsy
Copy link
Author
dieggsy commented Mar 11, 2025

Actually, CFFI does seem to still work on ACL11 as long as %foreign-funcall is not called. For example the CFFI ODBC port at sharplispers/clsql is loading and working ok.

@luismbo @sionescu ideally I'd still like feedback on how to proceed with this though.

@luismbo
Copy link
Member
luismbo commented Mar 11, 2025

Can you simplify the commit message to cffi-allegro: use SYSTEM::FF_FUNCALL for ACL >= 11?

(if I do it through GitHub it'll claim authorship)

cffi-allegro: use SYSTEM::FF_FUNCALL for ACL >= 11
6db6d61 
The internal system::ff-funcall function was renamed to
system::ff_funcall. This gets us most of the way there, but there are
still issues with vararg functions.
@dieggsy
Copy link
Author
dieggsy commented Mar 11, 2025

@luismbo done

@luismbo luismbo merged commit 48eaef6 into cffi:master Mar 11, 2025
@luismbo
Copy link
Member
luismbo commented Mar 11, 2025

Thanks. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dieggsy @luismbo
0