Support variable test URLs #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies which URLs are tested each night. Instead of having a hardcoded list in urls.js, the code now tries to load the list from a text file named urls.txt. The nightly GitHub Action now downloads this file from a URL which needs to be configured as a GitHub repository secret named TEST_PAGES_URL. If the file does not exist, running `yarn lighthouse` will now only run against the root page of the domain.
With this commit, the dashboard now includes all URLs ever tested, and includes a new column indicating the date of the most recent report.
|
I really like the suggested change to the column headings. I think it's clearer (and helpfully shorter!) :) |
|
Agreed! |
|
Thanks @caheberer @sonnakim! I've made the column change. I like the idea for introductory text but would prefer to implement in a future PR. |
This was referenced Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the list of URLs that get tested each night. Instead of testing a hardcoded list, the URLs to be tested are now read in from an external file. This file is downloaded from a secret URL which is stored in a GitHub repository secret named
TEST_PAGES_URL(if this secret is undefined, the fallback behavior is to only test the root of the website).In order to support the variable list of URLs, the dashboard design has been updated so that it always displays the (alphabetical) full list of URLs ever tested, but now includes a new column with the most recent report date.
Screenshots
@caheberer @sonnakim or others: any design suggestions on the column names? It feels a little more cramped now. Would it make sense to make a change something like this?
Another thought would be to add https://www.consumerfinance.gov to the header somehow and make all of the links relative.
Todos
Checklist