Remove Django 1.8 support #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow flexible version of djangorestframework - any version that support Django 1.11
chosak
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
This LGTM. I notice that the CHANGELOG.md for this repo is out of date. Should we bring it up to date either with this change, or as a separate PR?
The changelog was a manual process that was redudant to the github release log. It was becoming out of date because it's easy to forget to update it. Before replacing the changelog with a deprecation message, I 8000 did a review to ensure that all information from the changelog also exists in the github release log.
|
Good idea. Since the |
chosak
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.<
2C18
/span>
Suggestion cannot be applied right now. Please check back later.
setup.pyandtox.ini