You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds four new unit tests to GeocacheFilterTest to improve test coverage of the GeocacheFilter class, specifically focusing on filtersSame() and filterList() behavior under minimal configuration.
· Added test cases:
filtersSameReturnsTrueForEmptyFilters()
➤ Verifies that two empty filters (with no internal tree) are considered equal.
filtersSameReturnsFalseIfInconclusiveDiffers()
➤ Verifies that filters with different includeInconclusive values are considered unequal.
filtersSameReturnsFalseIfNameDiffers()
➤ Verifies that filters with different names are considered unequal.
filterListWithNullTreeKeepsAll()
➤ Ensures that calling filterList() with a null tree does not remove any geocaches from the list.
·All tests pass successfully on local fork (RJCheuk/cgeo-rjz).
These tests help verify edge-case behavior in minimal or default filter configurations.
Note: The same 9 integration test failures in connectedBasicDebugAndroidTest have appeared twice, once on Android 11 (emulator-5554) and once on Android 8.0.0.
All of the failures are from OC-related modules (OCConnectorTest, OkapiClientTest, ConnectorFactoryTest) and involve missing values (e.g., null geocodes) or assertions related to missing OKAPI keys.
My PR only adds unit tests to GeocacheFilterTest, does not modify any connector code, and all the new tests pass locally.
These failures seem unrelated to my changes and likely stem from CI environment limitations or external dependencies.
Could you kindly help verify if this is acceptable? Please let me know if I should take any action. Thanks again for your review and time!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds four new unit tests to GeocacheFilterTest to improve test coverage of the GeocacheFilter class, specifically focusing on filtersSame() and filterList() behavior under minimal configuration.
· Added test cases:
filtersSameReturnsTrueForEmptyFilters()
➤ Verifies that two empty filters (with no internal tree) are considered equal.
filtersSameReturnsFalseIfInconclusiveDiffers()
➤ Verifies that filters with different includeInconclusive values are considered unequal.
filtersSameReturnsFalseIfNameDiffers()
➤ Verifies that filters with different names are considered unequal.
filterListWithNullTreeKeepsAll()
➤ Ensures that calling filterList() with a null tree does not remove any geocaches from the list.
·All tests pass successfully on local fork (RJCheuk/cgeo-rjz).
These tests help verify edge-case behavior in minimal or default filter configurations.