keep current caches waypoints visible when enabling live mode #16981
Conversation
Job Summary for GradleUnit tests :: integration-tests
|
Job Summary for GradleUnit tests :: integration-tests
|
Job Summary for GradleUnit tests :: integration-tests
|
There was a problem hiding this comment.
I had given this a try some time ago, starting with "map type = target_geocode", but failed with the live loaders' complexity. I guess, the other way around, extending "plain mode" by displaying the target (if given), is valid as well.
Two things I've stumbled upon:
Do you want to handle the "set waypoint as target" case as well? You seem to, as you assign waypointId in getPlainMapWithTarget() (would not be needed for just setting a cache as target), but it does not fully work as expected:
Test case "set waypoint as target":
- Cache having two waypoints, one close by, one far away
- Map set to show 100 waypoints
- Open cache, set far away waypoint as target
- Enable live mode
- Scroll to the other waypoint => it does not show up, even if less than 100 caches are being displayed. It only shows up when showing at least the info sheet for the related cache.
- Same seems to be true for any other cache that has waypoints.
Method UnifiedMapType.isSingleCacheView() is no longer used.
It's 8000 fine as it's i guess. targeting a single WP shows only that WP, no other WPs of the cache. Then enabling live adds caches per normal live cache rules and keeps what was visible before - the sole WP. However it'd imho make sense to display all WPs when setting a signs single WP as target - but that'd be 1 step "before" what this PR implements. |
That part works as expected.
But it does not show the other caches' waypoints, even if configured to do so (waypoint limit > 0). |
fixes #16837