-
Notifications
You must be signed in to change notification settings - Fork 502
Course: Add support for resource sequencing in course and session views - refs rna-22586 #6330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ws - refs rna-22586
* @param {number=} sessionId - Optional session ID. | ||
* @returns {Promise<{ available: boolean, nextCourse: object|null }>} | ||
*/ | ||
getNextCourse: async (courseId, sessionId = 0) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
return $result; | ||
8000 | } | |
|
||
private function checkRequirementsOrDependentsForUser( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method checkRequirementsOrDependentsForUser
has 63 lines of code (exceeds 25 allowed). Consider refactoring.
); | ||
} | ||
|
||
private function getRequirementsOrDependents(int $resourceId, int $resourceType, string $itemType): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method getRequirementsOrDependents
has 36 lines of code (exceeds 25 allowed). Consider refactoring.
return $result; | ||
} | ||
|
||
private function checkRequirementsOrDependentsForUser( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function checkRequirementsOrDependentsForUser
has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
); | ||
} | ||
|
||
private function getRequirementsOrDependents(int $resourceId, int $resourceType, string $itemType): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function getRequirementsOrDependents
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Code Climate has analyzed commit 05c2357 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.