8000 auto.diod.in: remove bashisms by snogge · Pull Request #96 · chaos/diod · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

auto.diod.in: remove bashisms #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

snogge
Copy link
Contributor
@snogge snogge commented Mar 6, 2024

This patch was originally contributed by Roy Li to https://git.yoctoproject.org/meta-virtualization/

Copy link
Member
@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garlick
Copy link
Member
garlick commented Mar 6, 2024

If I recall, ubuntu-18.04 is no longer available in github ci so that's probably why those builds are not running.

I merged the other PR. Would you mind rebasing this on current master? I'd like to keep a linear history when possible.

Also - thanks for the improvements!

Signed-off-by: Roy Li <rongqing.li@windriver.com>
@snogge
Copy link
Contributor Author
snogge commented Mar 7, 2024

Branch rebased. Thank you for the quick response.

@snogge
Copy link
Contributor Author
snogge commented Mar 7, 2024

Merging this PR will fix #95.

@garlick garlick merged commit b4b5e8e into chaos:master Mar 7, 2024
@snogge snogge deleted the no-bashisms branch February 7, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0