database/raft: wait for ConfChange to be applied #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a new node to the cluster, wait for the conf change to be committed and applied before taking a state snapshot and responding to the new node. Previously, Join had a race condition between the application of the conf change entry and the taking of the snapshot. If the snapshot was taken before the conf change was committed or applied, the new node would try to boot its state machine from a state that did not include itself in the configuration. It could mistakeningly think that it is a single-node cluster and try to elect itself, panicking when its node id doesn't exist in the progress list: See issue #1330. Waiting for the conf change to be applied ensures that: * The /raft/join endpoint only returns if adding the node to the cluster was committed. * The snapshot returned from the /raft/join endpoint includes the new node in its configuration. This is a backport fix for the 1.2.x release line.
|
PTAL, backport of #1332 onto 1.2-stab 8000 le |
tessr
approved these changes
Jun 14, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new node to the cluster, wait for the conf change to be
committed and applied before taking a state snapshot and responding
to the new node.
Previously, Join had a race condition between the application of the
conf change entry and the taking of the snapshot. If the snapshot was
taken before the conf change was committed or applied, the new node
would try to boot its state machine from a state that did not include
itself in the configuration. It could mistakeningly think that it is a
single-node cluster and try to elect itself, panicking when its node
id doesn't exist in the progress list: See issue #1330.
Waiting for the conf change to be applied ensures that:
was committed.
node in its configuration.
This is a backport fix for the 1.2.x release line.