GRPC Client for Chalk Typescript Client #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
kelvin-chalk
commented
May 6, 2025
src/_http.ts
Outdated
There was a problem hiding this comment.
This got sundered into multiple files - _services/_http.ts and _services/_credentials.ts contain the major classes this contained, and several types got moved to _interface/_index.ts
kelvin-chalk
commented
May 6, 2025
| @@ -132,81 +139,6 @@ export type ChalkOnlineQueryResponseStatusKind = | |||
| | "partial_success" | |||
| | "error"; | |||
|
|
|||
| export type ChalkErrorCode = | |||
There was a problem hiding this comment.
most of the types removed here got moved into subfiles - this file was just getting impossible to navigate
kelvin-chalk
commented
May 6, 2025
| import { parseOnlineQueryResponse } from "./_response"; | ||
|
|
||
| export interface ChalkClientOpts { |
There was a problem hiding this comment.
got moved to _interface/_options.ts
kelvin-chalk
commented
May 6, 2025
| @@ -0,0 +1,429 @@ | |||
| import { ChalkError, isChalkError } from "../_errors"; | |||
There was a problem hiding this comment.
this file just a fraction of the _http.ts original file.
10000
kelvin-chalk
commented
May 6, 2025
| this.credentials = null; | ||
| } | ||
|
|
||
| async getEngineUrlFromCredentials( |
There was a problem hiding this comment.
while most of this file is just moving the file, this function is new.
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
kelvin-chalk
commented
May 7, 2025
src/_services/_grpc.ts
Outdated
| this.queryClient = this.queryClient = new QueryServiceClient( | ||
| stripProtocol(endpoint), | ||
| ChannelCredentials.createInsecure(), | ||
| { "grpc.enable_retries": maxNetworkRetries } |
There was a problem hiding this comment.
using the maxNetworkRetries correctly :)
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
michaelwiktorek
approved these changes
May 9, 2025
Signed-off-by: Kelvin Lu <kelvin@chalk.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a GPRC Client for the Chalk TS Client. This includes several major refactors of our code:
_interfacemodule, then sunders it into a directory with multiple subfilesChalkClientso that there is aChalkHTTPClientthat contains more functions (the grpc client only supports the criticalOnlineQuery,OnlineQueryBulk, andOnlineQueryMultifunction)