10000 Minor fixes by yebai · Pull Request #580 · chalk-lab/Mooncake.jl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Minor fixes #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

Minor fixes #580

merged 2 commits into from
May 18, 2025

Conversation

yebai
Copy link
Member
@yebai yebai commented May 18, 2025

#434 introduced a few minor issues, which this PR fixes.

@github-actions GitHub Actions
Copy link
Contributor

Mooncake.jl documentation for PR #580 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR580/

@yebai yebai merged commit 35d51a8 into main May 18, 2025
77 of 78 checks passed
@yebai yebai deleted the hg/doc-fixes branch May 18, 2025 22:00
@codecov Codecov
Copy link
codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬──
7B65
──────┬─────────────┬─────────┐
│                      Label │   Primal │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │ 100.0 ns │      1.8 │     1.1 │        5.61 │    8.21 │
│                  _sum_1000 │ 941.0 ns │     6.71 │  1360.0 │        33.5 │    1.09 │
│               sum_sin_1000 │  6.54 μs │     2.22 │    1.68 │        10.6 │    2.24 │
│              _sum_sin_1000 │   5.3 μs │     2.61 │   252.0 │        13.2 │    2.47 │
│                   kron_sum │ 292.0 μs │     60.9 │    5.34 │       230.0 │    13.0 │
│              kron_view_sum │ 333.0 μs │     42.6 │    10.5 │       214.0 │    9.43 │
│      naive_map_sin_cos_exp │  2.19 μs │      2.1 │ missing │        7.05 │    2.27 │
│            map_sin_cos_exp │  2.15 μs │     2.38 │    1.56 │        6.07 │    2.86 │
│      broadcast_sin_cos_exp │  2.21 μs │      2.3 │    2.38 │        1.47 │    2.27 │
│                 simple_mlp │ 416.0 μs │     4.58 │     1.6 │         6.6 │    3.21 │
│                     gp_lml │ 549.0 μs │      4.5 │    2.29 │     missing │    3.13 │
│ turing_broadcast_benchmark │  1.95 ms │     3.53 │ missing │        24.3 │ missing │
│         large_single_block │ 380.0 ns │     4.51 │  4460.0 │        31.7 │    2.24 │
└────────────────────────────┴──────────┴──────────┴─────────┴─────────────┴─────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yebai yebai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yebai
0