Improve calculation for number of ticks that can fit #6927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
approved these changes
Jan 7, 2020
etimberg
approved these changes
Jan 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master: https://codepen.io/kurkle/pen/GRgyGRxThis PR: https://codepen.io/benmccann/pen/QWwaoGK
Adding 1 to
ticksLimitin_autoSkipis wrong. The reason it was done was that the ticks may extend past the scale edge. However, what was not taken into account was that the ticks may not align perfectly with the scale edges. Look at "Sep 2014" on https://codepen.io/kurkle/pen/GRgyGRx. It's not right at the chart edge. So we should subtract one tick to make up for this and these effects cancel each other out.