8000 fix: make `YamlMap::get` throw `IncorrectTypeException` with clearer message when value is not of expected type by XYZboom · Pull Request #699 · charleskorn/kaml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make YamlMap::get throw IncorrectTypeException with clearer message when value is not of expected type #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2025
Merged

fix: make YamlMap::get throw IncorrectTypeException with clearer message when value is not of expected type #699

merged 2 commits into from
May 31, 2025

Conversation

XYZboom
Copy link
Contributor
@XYZboom XYZboom commented May 3, 2025

The "clear error message" fix for issue #697

@XYZboom XYZboom changed the title Make YamlMap::get throws IncorrectTypeException with clear message fix: make YamlMap::get throws IncorrectTypeException with clear message May 3, 2025
This was referenced May 5, 2025
Closed
Closed
charleskorn
charleskorn reviewed May 31, 2025
View reviewed changes
Copy link
Owner
@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XYZboom!

@charleskorn charleskorn changed the title fix: make YamlMap::get throws IncorrectTypeException with clear message fix: make YamlMap::get throw IncorrectTypeException with clearer message when value is not of expected type May 31, 2025
@charleskorn charleskorn changed the title fix: make YamlMap::get throw IncorrectTypeException with clearer message when value is not of expected type fix: make YamlMap::get throw IncorrectTypeException with clearer message when value is not of expected type May 31, 2025
@charleskorn
Copy link
Owner

Could you please run ./gradlew spotlessApply and commit the results?

@XYZboom
Copy link
Contributor Author
XYZboom commented May 31, 2025

Could you please run ./gradlew spotlessApply and commit the results?

Sure, wait a minute.

@XYZboom
Copy link
Contributor Author
XYZboom commented May 31, 2025

@charleskorn Commited the results after run ./graldew spotlessApply. And sorry I don't know a spotlessApply is needed before the commit. Maybe you can add this rule into the Contributing section in Readme.md

@charleskorn charleskorn merged commit 81f4e67 into charleskorn:main May 31, 2025
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.80.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XYZboom @charleskorn
0