fix: make YamlMap::get throws IncorrectTypeException with clear message #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge when the type mismatches.
This was referenced May 5, 2025
Remove type parameter of YamlMap::get or make it type safe or make the error message more clear
#697
Open
charleskorn
reviewed
May 5, 2025
| // if the value is not the given type, | ||
| // throws IncorrectTypeException with a clear message instead of ClassCastException. | ||
| return node as? T ?: throw IncorrectTypeException( | ||
| "Expected element to be ${T::class.simpleName} but is ${node::class.simpleName}", |
There was a problem hiding this comment.
Instead of using the class names, could you please use the plain English names instead (eg. instead of "YamlList", use "list", instead of "YamlMap", use "map" etc.)
There was a problem hiding this comment.
I noticed that class name is used here(https://github.com/charleskorn/kaml/blob/main/src/commonMain/kotlin/com/charleskorn/kaml/YamlNode.kt#L304), so I just want to keep it consistent with here. Do we need to make some changes here at YamlNode.kt:Line 304?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "clear error message" fix for issue #697