Add a configurable indent for sequences #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Thanks for the PR @Cloudate9. In general, this looks good to me, I just have a few minor suggestions and a question about one change.
src/commonMain/kotlin/com/charleskorn/kaml/YamlConfiguration.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
…nto feature/sequence-block-indent
…to solve our problems
|
I added clarification in the form of comments, where needed :) |
|
Looks great to me, thanks again @Cloudate9! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was previously no configurable indent for sequences. This pr enables this functionality
Previously
Now with
sequenceBlockIndentset to2(default0to preserve backwards compatibility)