new colour scheme dracul(dark) added and description typo fix #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The typo has since been fixed, but when I tried to implement your new color scheme in my fork, I noticed that the format for color schemes has changed and they include more colors now; maybe you could re-base and then complete the color scheme, with the current format. |
# Conflicts: # src/chatty/gui/components/settings/ColorSettings.java
|
I have just implemented it; now, I'm not sure about how you would do this, but the PR as it stands has a lot more commits than the actual difference between the two branches. At worst, you could just close this PR and make a new one, which will show very few commits for the maintainers to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dracul(dark) added scheme