8000 feat: track gossiping per (chat, fingerprint) pair by link2xt · Pull Request #6787 · chatmail/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ core Public

feat: track gossiping per (chat, fingerprint) pair #6787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

feat: track gossiping per (chat, fingerprint) pair #6787

wants to merge 0 commits into from

Conversation

link2xt
Copy link
Collaborator
@link2xt link2xt commented Apr 8, 2025 •
edited
Loading

This change simplifies
updating the gossip timestamps
when we receive a message
because we only need to know
the keys received in Autocrypt-Gossip
header and which chat the message is
assigned to.
We no longer need to iterate
over the member list.

This is a preparation
for PGP contacts
and member lists that contain
key fingerprints rather than
email addresses.

This change also removes encryption preference
from Autocrypt-Gossip header.
It SHOULD NOT be gossiped
according to the Autocrypt specification
and we ignore encryption preference anyway
since 1.157.0.

@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch 4 times, most recently from 2e77b16 to a4533ec Compare April 8, 2025 20:01
@link2xt link2xt mentioned this pull request Apr 8, 2025
Merged
@link2xt
Copy link
Collaborator Author
link2xt commented Apr 8, 2025

This also fixes Autocrypt-Gossip being sent in broadcast lists and disclosing recipient email addresses since #6781

@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from d2412c8 to 49d5c37 Compare April 8, 2025 20:13
@link2xt link2xt marked this pull request as draft April 8, 2025 20:19
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from 49d5c37 to e9eda8e Compare April 8, 2025 20:24
@link2xt link2xt changed the base branch from main to link2xt/no-broadcast-gossip April 8, 2025 20:49
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from e9eda8e to 7409782 Compare April 8, 2025 20:54
Base automatically changed from link2xt/no-broadcast-gossip to main April 8, 2025 21:50
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from 7409782 to 3560926 Compare April 9, 2025 00:17
@link2xt link2xt changed the base branch from main to link2xt/port-test_delete_deltachat_folder April 9, 2025 00:23
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from 3560926 to f93c415 Compare April 9, 2025 00:24
@link2xt link2xt force-pushed the link2xt/port-test_delete_deltachat_folder 8000 branch from 0213cc3 to cba2cdd Compare April 9, 2025 00:24
@link2xt link2xt marked this pull request as ready for review April 9, 2025 03:17
@link2xt link2xt mentioned this pull request Apr 9, 2025
Open
@link2xt link2xt force-pushed the link2xt/port-test_delete_deltachat_folder branch from cba2cdd to 3e8987b Compare April 9, 2025 13:28
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from f93c415 to 1be9d94 Compare April 9, 2025 13:29
Base automatically changed from link2xt/port-test_delete_deltachat_folder to main April 9, 2025 13:43
@link2xt link2xt requested review from Hocuri and iequidoo April 10, 2025 18:03
@link2xt
Copy link
Collaborator Author
link2xt commented Apr 11, 2025

If #6724 is merged first, I will rebase the migration.

iequidoo
iequidoo reviewed Apr 11, 2025
View reviewed changes
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch 2 times, most recently from 531d072 to 6333ddb Compare April 11, 2025 15:30
@link2xt link2xt closed this Apr 12, 2025
@link2xt link2xt force-pushed the link2xt/gossip-fingerprint branch from 6333ddb to 9f5e608 Compare April 12, 2025 02:51
@link2xt
Copy link
Collaborator Author
link2xt commented Apr 12, 2025

This is merged as 9f5e608

@link2xt link2xt deleted the link2xt/gossip-fingerprint branch April 12, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iequidoo iequidoo iequidoo approved these changes

@Hocuri Hocuri Awaiting requested review from Hocuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@link2xt @iequidoo
0