Updates for compatibility with t 8000 usd 1.x #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ce716 to
4d52cb5
Compare
|
Changes look good, but please rebase so we know that everything still works for sure :) |
|
Huh. I rebased after you merged the new CI workflow, but it didn't run. I can try again. If that doesn't work, maybe we need a |
4d52cb5 to
5bf0683
Compare
|
🤔 oh interesting. let me add that then |
|
Just added pull_request events to trigger tests: 31a7a39 It just occurred to me that draft PRs might not trigger test runs. |
5bf0683 to
f2d6d6e
Compare
chen-anders
approved these changes
Feb 4, 2021
|
I'll post again once I've had a chance to properly test this on our end. There was a bit of yak shaving to do before the actual tusd upgrade. |
|
Looks good on my end 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.x release of tusd introduced a new
Lockinterface that's separate fromLocker. This PR introduces aLocktype that conforms to the upstream interface and makes the locker compatible with newer versions of tusd. I tried to use a light touch on everything else so that the breaking changes are few.Still testing, but feedback is welcome.
Ohai @chen-anders :) 👋