8000 Add DataMirror API for currentInstancePorts. by mikeurbach · Pull Request #4362 · chipsalliance/chisel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add DataMirror API for currentInstancePorts. #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2024
Merged

Add DataMirror API for currentInstancePorts. #4362

merged 3 commits into from
Aug 21, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This allows users to query an Instance without it being closed or forcing it to close, which can be useful in atModuleBodyEnd and other scenarios.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach
Add DataMirror API for currentInstancePorts.
b60daab 
This allows users to query an Instance without it being closed or
forcing it to close, which can be useful in atModuleBodyEnd and other
scenarios.
@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Aug 21, 2024
@mikeurbach mikeurbach requested a review from jackkoenig August 21, 2024 00:26
jackkoenig
jackkoenig reviewed Aug 21, 2024
View reviewed changes
jackkoenig
jackkoenig approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor
@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see comments

@mikeurbach mikeurbach merged commit b808a97 into main Aug 21, 2024
15 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/datamirror-instance-ports branch August 21, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Feature New feature, will be included in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeurbach @jackkoenig
0