[chiselsim] Rewrite EphemeralSimulator in terms of DefaultSimulator #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a type class implementation generator that can be used to create temporary directories for Chiselsim simulations. This is building twoards collapsing the `EphemeralSimulator` into the `DefaultSimulator`. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Using the new type class implementation generator `HasTestingDirectory.temporary`, rewrite the `EphemeralSimulator` to be implemented using the `DefaultSimulator`. This is working towards completely deleting the `EphemeralSimulator` in favor of the `DefaultSimulator`. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
|
Nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I'm working towards developing a common simulator API. Part of the problem right now is that the
DefaultSimulatorandEphemeralSimulatorare different enough that they can't be easily unified.Unify the
DefaultSimulatorandEphemeralSimulatorby rewriting the latter using the former. This is done by writing a newHasTestingDirectorytype class implementation generator calledtemporarywhich will do all the work of what theEphemeralSimulatorwas previously doing.Release Notes
chisel3.simulator.HasTestingDirectory.temporarytype class implementation generator for control of temporary directory creation (with optional auto-deletion).