8000 (1password) Add screenshot by flcdrg · Pull Request #2657 · chocolatey-community/chocolatey-packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(1password) Add screenshot #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(1password) Add screenshot #2657

wants to merge 1 commit into from

Conversation

flcdrg
Copy link
Contributor
@flcdrg flcdrg commented May 1, 2025 •
edited
Loading

Description

  • Fixes broken link in package description
  • Replace screenshot for 1password8 package (previous file was somehow corrupted)
  • Ensure Git treats .webp files as binary (may be the cause of previous point)

Motivation and Context

Fix broken link(s)

How Has this Been Tested?

Not really possible as files aren't include in nupkg, just linked to from package descriptions

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My pull request is not coming from the master branch.
  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment. Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@flcdrg flcdrg enabled auto-merge May 1, 2025 02:56
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@flcdrg flcdrg changed the title Add screenshot for 1password (1password) Add screenshot May 1, 2025
@flcdrg
Copy link
Contributor Author
flcdrg commented May 1, 2025

As far as I can tell, both build errors are outside of my control?

@flcdrg
Add screenshot for 1password
7c867e3 
- Fixes broken link in package description
- Replace screenshot for 1password8 package (previous file was somehow corrupted)
- Ensure Git treats .webp files as binary (may be the cause of previous point)
@flcdrg flcdrg force-pushed the fix-missing-1password-screenshot branch from 0ed0b8f to 7c867e3 Compare May 4, 2025 23:46
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flcdrg @AppVeyorBot
0