-
Notifications
You must be signed in to change notification settings - Fork 85
Release 0.21.5 - bugfix release candidate #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -15,6 +15,13 @@ Bugfixes | |||
- Bug in equilibration detection #1: The user was allowed to specify ``statistical_inefficiency`` without specifying ``n_equilibration_iterations``, which doesn't make sense, as ``n_equilibration_iterations`` and ``n_effective_max`` cannot be computed from ``statistical_inefficiency`` alone. Fixed by preventing user from specifying ``statistical_inefficiency`` without ``n_equilibration_iterations``. Issue `#609 <https://github.com/choderalab/openmmtools/issues/609>`_ (PR `#610 <https://github.com/choderalab/openmmtools/pull/610>`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just discussed this, but just to set out the reminder: We want to start each of these with a clear description of the impact of the bug so users can tell if this would have impacted their work and may improve their simulations if they re-run them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jchodera : Do you have suggestions on how to make this one clearer? I thought I had already made this one clear but maybe its still not clear enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that one is clear. It was probably the others that were unclear. I just committed the changes to these ones.
…ask for a changelog message.
@ijpulidos while we are working on this, any new deps or deps we can drop? |
docs/releasehistory.rst
Outdated
@@ -6,15 +6,22 @@ Release History | |||
|
|||
Changed behaviors | |||
----------------- | |||
- ``LangevinDynamicsMove`` now uses ``openmm.LangevinMiddleIntegrator`` (a BAOAB integrator) instead of `openmm.LangevinIntegrator`` (an OBABO integrator). | |||
- ``LangevinDynamicsMove`` now uses ``openmm.LangevinMiddleIntegrator`` (a BAOAB integrator) instead of ``openmm.LangevinIntegrator`` (an OBABO integrator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijpulidos : I think we also wanted to fix the formatting of this one, because its appearing as bolded and italicized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed this in the commit below
@ijpulidos mentioned to me after the dev sync that there are no changes in dependencies with this release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for making this so clear!
Description
Release candidate PR for Bugfix release 0.21.5
Status