Remove restriction on online_analysis_interval and checkpoint_interval #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
IAlibay
reviewed
Apr 30, 2025
| if self.online_analysis_interval: | ||
| if self.online_analysis_interval % self._reporter.checkpoint_interval != 0: | ||
| raise ValueError(f"Online analysis interval: {self.online_analysis_interval}, must be a " | ||
| f"multiple of the checkpoint interval: {self._reporter.checkpoint_interval}") | ||
| logger.warning("An online_analysis_interval that is not a multiple of the checkpoint_interval can lead to redundant information in the real time yaml file.") |
There was a problem hiding this comment.
"after recovering from checkpoints?" or something like that?
Specify that redundant information is added to the real time analysis file only if recovering from a checkpoint older than that information.
|
@ijpulidos ready for review! |
ijpulidos
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the requirement that the
online_analysis_intervalis a multiple of thecheckpoint_interval.closes #770
Todos
Status
Changelog message