[ENH] Set ef_search on hnsw index load #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadB
approved these changes
Mar 27, 2025
A6AA
1 task
sanketkedia
added a commit
to chroma-core/chroma
that referenced
this pull request
Mar 27, 2025
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - After chroma-core/hnswlib#31, need to update all callsites of hnsw.load() to pass in ef_search obtained from collection config - New functionality - ... ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you load an existing hnsw index, it always gets loaded with ef_search = 10 and we don't override it anywhere in the code. This leads to recall degradation. Fixed by taking ef_search as parameter to load. In the next PR, will update consumers to pass in this from config.