Fix moduleName resolution for Storybook files with import cycles. #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix moduleName resolution for Storybook files with import cycles.
|
📦 Package Size: 5448 KB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
- Coverage 70.01% 69.98% -0.03%
==========================================
Files 202 202
Lines 7361 7357 -4
Branches 1301 1302 +1
==========================================
- Hits 5154 5149 -5
- Misses 2184 2185 +1
Partials 23 23 ☔ View full report in Codecov by Sentry. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of our webpack builder is now emitting
resolvedModule, or perhaps always did in an undocumented manner.This is generally not a problem, as we used
resolvedModulefor rspack and it is generallynullfrom webpack, but when you have import cycles you can get a value which is not what we desire from it.Removing it works with current rspack builders as well.
📦 Published PR as canary version:
11.26.2--canary.1157.13548091166.0✨ Test out this PR locally via:
npm install chromatic@11.26.2--canary.1157.13548091166.0 # or yarn add chromatic@11.26.2--canary.1157.13548091166.0