8000 :pencil2: Update help text to reflect actual state of exitOnceUploaded. by jwir3 · Pull Request #1169 · chromaui/chromatic-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

✏️ Update help text to reflect actual state of exitOnceUploaded. #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

jwir3
Copy link
Contributor
@jwir3 jwir3 commented Apr 2, 2025

We previously suggested that users use the flag --exit-once-uploaded, but now that we have a workflow parameter for this, our github action can actually take advantage of reporting the correct way to pass this option.

Fixes CAP-2374.

📦 Published PR as canary version: 11.28.1--canary.1169.14247692752.0

✨ Test out this PR locally via:

npm install chromatic@11.28.1--canary.1169.14247692752.0
# or 
yarn add chromatic@11.28.1--canary.1169.14247692752.0

We previously suggested that users use the flag --exit-once-uploaded,
but now that we have a workflow parameter for this, our github action
can actually take advantage of reporting the correct way to pass this
option.

Fixes CAP-2374.
@jwir3 jwir3 added tiny Estimate: <= 2 hours patch Auto: Increment the patch version when merged labels Apr 2, 2025
@jwir3 jwir3 requested a review from a team April 2, 2025 17:23
@jwir3 jwir3 self-assigned this Apr 2, 2025
Copy link
Contributor
github-actions bot commented Apr 2, 2025

📦 Package Size: 5580 KB
✅ Compared to main: 0 KB b5c5fb0 (5580 KB)

Copy link
codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (b5c5fb0) to head (4490715).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
node-src/ui/messages/info/speedUpCI.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   70.19%   70.19%           
=======================================
  Files         203      203           
  Lines        7385     7385           
  Branches     1308     1310    +2     
=======================================
  Hits         5184     5184           
  Misses       2178     2178           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jwir3 jwir3 added the release Auto: Create a `latest` release when merged label Apr 2, 2025
Copy link
Contributor
@justin-thurman justin-thurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you think it's worth keeping the reference to the --exit-once-uploaded flag, since it is still a valid choice? Though it would make this help message a bit overloaded. I'm fine either way.

@jwir3 jwir3 added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Apr 3, 2025
@jwir3 jwir3 merged commit aa1210d into main Apr 3, 2025
28 of 32 checks passed
@jwir3 jwir3 deleted the jwir3/cap-2374-update-help-text branch April 3, 2025 16:11
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.28.1 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged tiny Estimate: <= 2 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0