Return additional build info on action rerun #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-thurman
commented
Apr 16, 2025
| specCount | ||
| testCount | ||
| changeCount | ||
| errorCount: testCount(statuses: [BROKEN]) |
There was a problem hiding this comment.
I copied this from other implementations of this field, e.g., snapshot.ts.
|
📦 Package Size: 5576 KB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
=======================================
Coverage 70.00% 70.01%
=======================================
Files 202 202
Lines 7314 7316 +2
Branches 1299 1301 +2
=======================================
+ Hits 5120 5122 +2
Misses 2171 2171
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codykaup
approved these changes
Apr 16, 2025
notes on changeCount
dad964f to
891a6cd
Compare
|
@codykaup, addressed your changes. I also reran the CLI manually and confirmed the new values are working as expected. |
codykaup
approved these changes
Apr 17, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue whereby reruns of the GitHub action, which a user might trigger after approving visual changes, would not provide updated values for things like
testCount,changeCount, etc. This was happening because we were only pulling these values from thectx.buildfield, if it was defined. This PR updates that logic to pull fromctx.rebuildForBuildifctx.buildis undefined. I've also added the relevant fields to theLastBuildQueryGQL query so we're pulling that information from the index.Manual testing
I've verified through the Apollo GQL dashboard that the fields I've added to
LastBuildQuerywork as expected. I also ran a build with the CLI locally and triggered theSkipping rebuild of an already fully passed/accepted build, and confirmed that the relevant count values are being populated as expected.📦 Published PR as canary version:
11.28.2--canary.1174.14517169208.0✨ Test out this PR locally via:
npm install chromatic@11.28.2--canary.1174.14517169208.0 # or yarn add chromatic@11.28.2--canary.1174.14517169208.0