8000 Adding support for MIDI 2.0 protocol by chris-zen · Pull Request #36 · chris-zen/coremidi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding support for MIDI 2.0 protocol #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 26, 2022
Merged

Adding support for MIDI 2.0 protocol #36

merged 29 commits into from
Mar 26, 2022

Conversation

chris-zen
Copy link
Owner
@chris-zen chris-zen commented Feb 21, 2022 •
edited
Loading

This PR adds support for MIDI 2.0 and cleans up some other things:

  • Added EventList and EventBuffer support.
  • Added input_port_with_protocol and virtual_destination_with_protocol to Client.
  • input_port_with_protocol creates a InputPortWithContext<T> that allows to define a context to every source that is connected through connect_source.
  • OutputPort::send and VirtualSource::received can work with both PacketList and EventList.
  • Using blocks for callbacks from Client.
  • Client notifications allowed by reference or ownership.
  • Simplified the PacketList and PacketBuffer implementations.
  • Added set_property and get_property to Object.
  • Conversions between Source, Destination, VirtualSource, VirtualDestination, Device, Entity and Object.
  • Updated all the examples and documentation to use EventList.

@chris-zen chris-zen mentioned this pull request Feb 28, 2022
Closed
@chris-zen chris-zen marked this pull request as ready for review March 4, 2022 22:38
This was referenced Mar 4, 2022
Merged
Open
@chris-zen chris-zen merged commit 267e269 into master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chris-zen
0