8000 Encryption fixes for route/rule management by jrfastab · Pull Request #8000 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Encryption fixes for route/rule management #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

Encryption fixes for route/rule management #8000

merged 1 commit into from
May 15, 2019

Conversation

jrfastab
Copy link
Contributor
@jrfastab jrfastab commented May 14, 2019 •
edited
Loading

Include table in route specifier so deleting IPsec routes in the encryption routing table will work.

This change is Reviewable

@jrfastab jrfastab requested a review from a team May 14, 2019 04:56
@jrfastab
Copy link
Contributor Author

test-me-please

@coveralls
Copy link
coveralls commented May 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 41.716% when pulling e73d7c2 on route-fixes into 2e97212 on master.

@jrfastab
Copy link
Contributor Author

hit timeout after 'Test Suite Passed` going to retry.
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/12283/console

@jrfastab
Copy link
Contributor Author

test-me-please

@jrfastab
cilium: encode table attribute in Route delete
e73d7c2 
Deleting routes from encryption side was failing because we use a
rule+table for encryption/decryption. This patch includes the table
id in the route delete to fix this.

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
@jrfastab
Copy link
Contributor Author

test-me-please

@jrfastab
Copy link
Contributor Author

test-me-please

@tgraf tgraf added kind/bug This is a bug in the Cilium logic. needs-backport/1.5 labels May 14, 2019
@jrfastab jrfastab mentioned this pull request May 14, 2019
Merged
@tgraf tgraf merged commit 6667938 into master May 15, 2019
@tgraf tgraf deleted the route-fixes branch May 15, 2019 10:01
@nebril nebril mentioned this pull request May 15, 2019
Closed
@jrfastab jrfastab mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrfastab @coveralls @tgraf @vadorovsky @nebril
0