iptables: Fatal when IPv6 is enabled but corresponding kernel modules are missing #18941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
approved these changes
Feb 26, 2022
Maybe this would be better worded as a full sentence?
|
YutaroHayakawa
approved these changes
Feb 28, 2022
69beae8 to
5ffe025
Compare
|
@pchaigno Fixed the commit message. Thanks! |
|
@vadorovsky Oh, sorry. The previous commit title was fine (and fit within the character limit). I meant to suggest changing the release note :) |
|
@pchaigno I had an intention to change it also in release notes and PR title, but seems like lack of coffee made me to not do it. Fixed now. :) |
This comment was marked as resolved.
This comment was marked as resolved.
|
@vadorovsky Could you please rebase? Many tests are failing because the PR branch is pretty old. |
… are missing Before this change, when Cilium was running with --enable-ipv6 option, we were only logging a warning, but then the rest of iptables.go module was inserting ip6tables rules anyway. That resulted in errors, because inserting such rules is impossible without IPv6 netfilter presence in the kernel. This change fixes that by a fatal error in situation when IPv6 is enabled in Cilium, but not supported by the kernel. In such situations, users should either disable IPv6 in Cilium or load the needed kernel modules. Fixes: cilium#18904 Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
|
sorry for doing it so late |
|
No problem. /test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when Cilium was running with --enable-ipv6 option,
we were only logging a warning, but then the rest of iptables.go module
was inserting ip6tables rules anyway. That resulted in errors, because
inserting such rules is impossible without IPv6 netfilter presence in
the kernel.
This change fixes that by a fatal error in situation when IPv6 is
enabled in Cilium, but not supported by the kernel. In such situations,
users should either disable IPv6 in Cilium or load the needed kernel
modules.
Fixes: #18904
Signed-off-by: Michal Rostecki vadorovsky@gmail.com