ui: v0.9.0 images and drop envoy proxy container #19565
Conversation
fd0a64a to
f96ed87
Compare
7145b08 to
10dae03
Compare
| location /api { | ||
| proxy_http_version 1.1; | ||
| proxy_pass_request_headers on; | ||
| proxy_hide_header Access-Control-Allow-Origin; | ||
| proxy_pass http://127.0.0.1:8090; |
There was a problem hiding this comment.
is this configuration also perform prefix rewrite like what we have before with envoy ?
There was a problem hiding this comment.
We have appropriate change on UI backend itself, now it actually listens on /api path https://github.com/cilium/hubble-ui/blob/bfefef23928e159f8416b42612097a83ba0ae67f/backend/main.go#L59-L63
There was a problem hiding this comment.
so does it mean that with this change hubble ui image must be at least v0.9.0+ ? If it's the case, what do you think about adding such validation here https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/validate.yaml ?
There was a problem hiding this comment.
Correct. How could I run this validation to check if wrote this right?
There was a problem hiding this comment.
it will be run automatically as part of helm install or helm template with supplied values.
10dae03 to
571f344
Compare
|
Commit 9fa62fe2e61e4fd1a42495a575291b9da4b31ee6 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
9fa62fe to
ab5f51c
Compare
cilium/cilium#19565 removed hubble-ui-proxy from the Helm chart. Remove all the references to hubble-ui-proxy in the OLM templates. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
cilium/cilium#19565 removed hubble-ui-proxy from the Helm chart. Remove all the references to hubble-ui-proxy in the OLM templates. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Previously we used envoy proxy container to convert grpc-web traffic to
true grpc traffic, so ui backend accepts real grpc traffic. There is
an alternative approach to use special wrapper
for grpc service on backend:
https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb
Related code changes on hubble-ui itself was implemented in this PR:
cilium/hubble-ui#226
This also bumps UI images to v0.9.0 with actual implementation.
Signed-off-by: Dmitry Kharitonov dmitry@isovalent.com