workflow: l4lb: pass correct path for PR checkout #20009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
approved these changes
May 30, 2022
test/l4lb/test.sh
Outdated
| @@ -4,7 +4,7 @@ set -eux | |||
|
|
|||
| IMG_OWNER=${1:-cilium} | |||
| IMG_TAG=${2:-latest} | |||
| PULL_REQUEST_CHECKOUT=${3:-../..} | |||
| HELM_CHART_DIR=${3:-/vagrant/pull-request/install/kubernetes/cilium} | |||
There was a problem hiding this comment.
For backward compatibility:
Suggested change
| HELM_CHART_DIR=${3:-/vagrant/pull-request/install/kubernetes/cilium} | |
| HELM_CHART_DIR=${3:-/vagrant/install/kubernetes/cilium} |
Passing ${{ github.workspace }}/pull-request to the init.sh script as
path of the PR checkout is incorrect, as inside the VM the repository
will be under a different path.
Instead of that, pass the correct absolute path for the PR checkout.
Moreover, checkout first the upstream repo (under cilium/cilium) and
only after that the PR one (under cilium/cilium/pull-request), as
otherwise the upstream checkout will nuke the directory with PR one.
This PR includes only the changes related to test/l4lb/test.sh, as the
workflow is being updated on the master PR #20007.
Fixes: #20003
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
40d6405 to
f92079e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing ${{ github.workspace }}/pull-request to the init.sh script as
path of the PR checkout is incorrect, as inside the VM the repository
will be under a different path.
Instead of that, pass the correct absolute path for the PR checkout.
Moreover, checkout first the upstream repo (under cilium/cilium) and
only after that the PR one (under cilium/cilium/pull-request), as
otherwise the upstream checkout will nuke the directory with PR one.
This PR includes only the changes related to test/l4lb/test.sh, as the
workflow is being updated on the master PR #20007.
Fixes: #20003