[v1.11] add support to override not ready taint to be ignored by the CA #20183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit c1c9716 ] [ Backporter's notes: Minor conflicts in values.yaml, go imports ] If you scale a node pool down to zero nodes the Cluster Autoscaler won't add new nodes because pending pods don't tolerate the cilium agent-not-ready taint. If you're managing your own CA you can ignore the cilium taint with a command line flag on the CA. However if you're running on managed k8s (e.g. GKE), you may not have access to configure the CA, and will need to use a custom taint prefix to be ignored by the autoscaler when scaling up from zero nodes in a pool. This commit adds config to add a prefix to the agent-not-ready taint so it can be ignored by the cluster-autoscaler. Fixes: #19241 Co-authored-by: Xiaoxi Huang <Xiaoxi@ascend.io> Signed-off-by: Joseph Stevens <thejosephstevens@gmail.com> Signed-off-by: Joe Stringer <joe@cilium.io>
michi-covalent
approved these changes
Jun 13, 2022
|
/test-backport-1.11 |
ADEB
|
runtime job hit #18958 , marked fix for backport to v1.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ upstream commit c1c9716 ]
[ Backporter's notes: Minor conflicts in values.yaml, go imports ]
If you scale a node pool down to zero nodes the Cluster Autoscaler won't
add new nodes because pending pods don't tolerate the cilium
agent-not-ready taint. If you're managing your own CA you can ignore
the cilium taint with a command line flag on the CA. However if you're
running on managed k8s (e.g. GKE), you may not have access to configure
the CA, and will need to use a custom taint prefix to be ignored by the
autoscaler when scaling up from zero nodes in a pool.
This commit adds config to add a prefix to the agent-not-ready taint so
it can be ignored by the cluster-autoscaler.
Related: #19241
Backports: #19247