8000 Fixed CCNP garbage collection by zuzzas · Pull Request #21394 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed CCNP garbage collection #21394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fixed CCNP garbage collection #21394

merged 1 commit into from
Oct 12, 2022

Conversation

zuzzas
Copy link
Contributor
@zuzzas zuzzas commented Sep 22, 2022 •
edited
Loading

CCNPs are converted internally into CNPs, but metadata.name has been forgotten.

Fixes: #21393

Fixed CCNP garbage collection

@zuzzas
Fixed CCNP garbage collection
1b55b43 
CCNPs are converted internally into CNPs, but metadata.name has been forgotten

Fixes cilium#21393

Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
@zuzzas zuzzas requested a review from a team as a code owner September 22, 2022 07:06
@zuzzas zuzzas requested a review from nebril September 22, 2022 07:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 22, 2022
aanm
aanm approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member
@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. It's a regression introduced by 8e9d511

@aanm
Copy link
Member
aanm commented Sep 22, 2022

/test

@aanm aanm added needs-backport/1.10 and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 22, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 22, 2022
@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. area/operator Impacts the cilium-operator component and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 22, 2022
@aanm
Copy link
Member
aanm commented Sep 22, 2022 •
edited by maintainer-s-little-helper bot
Loading

/test

Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig Check BPF masquerading with ip-masq-agent DirectRouting

Failure Output

FAIL: Failed to add ip route

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-net-next so I can create one.

@zuzzas
Copy link
Contributor Author
zuzzas commented Sep 29, 2022

@aanm
Can I do anything? e2e test failures seem unrelated.

@gandro
Copy link
Member
gandro commented Sep 29, 2022

@gandro
Copy link
Member
gandro commented Sep 29, 2022

/test-runtime

@gandro
Copy link
Member
gandro commented Sep 29, 2022

/ci-multicluster

@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 12, 2022
@qmonnet
Copy link
Member
qmonnet commented Oct 12, 2022

From maintainer's little helper edit (Jenkins logs are no longer available), I assume the failure on k8s-1.25-kernel-net-next was an occurrence of #18054. Unrelated to the current PR, all seems in order.

@qmonnet qmonnet merged commit 694892c into cilium:master Oct 12, 2022
@zuzzas zuzzas deleted the fix-ccnp-status-updates branch October 13, 2022 04:18
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
Merged
6 tasks
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
Merged
3 tasks
@qmonnet qmonnet mentioned this pull request Oct 19, 2022
Merged
3 tasks
This was referenced Nov 15, 2022
Merged
Closed
Merged
Merged
@joestringer joestringer added backport-done/1.10 backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.10 labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCNP garbage collection does not work
6 participants
@zuzzas @aanm @gandro @qmonnet @nebril @joestringer
0