8000 workflows: fix skip condition for encryption tests in datapath conformance by tklauser · Pull Request #22763 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

workflows: fix skip condition for encryption tests in datapath conformance #22763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

workflows: fix skip condition for encryption tests in datapath conformance #22763

merged 1 commit into from
Dec 22, 2022

Conversation

tklauser
Copy link
Member

Currently, the encryption tests are e.g. run on kernel 5.4 [1], even though encryption is disabled [2].

[1] https://github.com/cilium/cilium/actions/runs/3706274238/jobs/6281282090
[2] https://github.com/cilium/cilium/actions/runs/3706274238/workflow#L130

Noticed while debugging #22754.

@tklauser tklauser requested a review from brb December 15, 2022 19:09
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 15, 2022
@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label Dec 15, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 15, 2022
@tklauser
Copy link
Member Author
tklauser commented Dec 15, 2022 •
edited
Loading

Encryption tests are now correctly skipped with this change and the test commit: https://github.com/cilium/cilium/actions/runs/3707194197/jobs/6283316522

Removing test commit and marking as ready for review.

@tklauser tklauser force-pushed the pr/tklauser/dp-conformance-encryption-skip branch from 9f5d682 to c5546a5 Compare December 15, 2022 19:36
@tklauser tklauser marked this pull request as ready for review December 15, 2022 19:36
@tklauser tklauser requested review from a team as code owners December 15, 2022 19:36
@tklauser tklauser requested a review from nbusseneau December 15, 2022 19:36
brb
brb approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member
@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 21, 2022
@tklauser
workflows: fix skip condition for encryption tests in datapath confor…
2a1d8a5 
…mance

Currently, the encryption tests are e.g. run on kernel 5.4 [1], even
though encryption is disabled [2].

[1] https://github.com/cilium/cilium/actions/runs/3706274238/jobs/6281282090
[2] https://github.com/cilium/cilium/actions/runs/3706274238/workflow#L130

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/dp-conformance-encryption-skip branch from c5546a5 to 2a1d8a5 Compare December 21, 2022 13:14
@borkmann borkmann merged commit de7c96f into master Dec 22, 2022
@borkmann borkmann deleted the pr/tklauser/dp-conformance-encryption-skip branch December 22, 2022 16:13
@aditighag aditighag mentioned this pull request Jan 9, 2023
Merged
@aditighag aditighag added backport-pending/1.13 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 labels Jan 9, 2023
@joestringer joestringer mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tklauser @brb @nbusseneau @borkmann @aditighag
0