8000 Bump Linux minimum version to 4.19.57 (or equivalent) by joestringer · Pull Request #23124 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Linux minimum version to 4.19.57 (or equivalent) #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

joestringer
Copy link
Member
@joestringer joestringer commented Jan 16, 2023

I've bumped the minimum here with a recommendation for 4.19.57 "or
equivalent" with the understanding that sometimes distributions may
choose to backport significant amounts of newer kernel functionality
into older releases, such as RHEL. The daemon itself will still rely on
feature probes for the features that it requires in order to operate, so
at runtime it should continue to work on older kernels as long as the
kernel functionality is there. However, over time we will begin to
remove and deprecate support for kernels older than this target version.

I've also bumped the distribution versions to more recently supported
versions of distributions which match this kernel dependency.

Fixes: #22586

@joestringer joestringer requested review from a team as code owners January 16, 2023 22:50
@joestringer joestringer added needs-backport/1.13 release-note/major This PR introduces major new functionality to Cilium. labels Jan 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 16, 2023
@joestringer joestringer changed the title Bump Linux minimum version to 4.19.57 Bump Linux minimum version to 4.19.57 (or equivalent) Jan 16, 2023
@joestringer joestringer self-assigned this Jan 16, 2023
Copy link
Member
@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I've bumped the minimum here with a recommendation for 4.19.57 "or
equivalent" with the understanding that sometimes distributions may
choose to backport significant amounts of newer kernel functionality
into older releases, such as RHEL. The daemon itself will still rely on
feature probes for the features that it requires in order to operate, so
at runtime it should continue to work on older kernels as long as the
kernel functionality is there. However, over time we will begin to
remove and deprecate support for kernels older than this target version.

I've also bumped the distribution versions to more recently supported
versions of distributions which match this kernel dependency.

Signed-off-by: Joe Stringer <joe@cilium.io>
These features rely on LPM maps, so they printed a helpful message in
case the user was running one of those older kernels. Now that we don't
support those kernel versions, we don't need to emit such tips.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/deprecate-v4.9 branch from 173f43e to 26e6c0e Compare January 16, 2023 23:56
@joestringer joestringer added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/major This PR introduces major new functionality to Cilium. labels Jan 17, 2023
Copy link
Member
@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! It'll be good to bring this up in the next community meeting, especially in the context of datapath testing.

@joestringer
Copy link
Member Author

@aditighag yep we can revisit it this Wednesday 👍 . For now, this isn't actually removing the code that supports those older versions; CI is still depending on 4.9 for now for instance. But this is signalling that we will not support 4.9 for the full lifecycle of the Cilium 1.13.x release series.

@julianwiedmann
Copy link
Member

FWIW - with 4.9 being EOL on kernel.org now, I think we have every reason to also phase out support for it in Cilium.

@joestringer
Copy link
Member Author

Cool, thanks for the update Julian. We discussed this item briefly also during the community meeting today, and agreed that there are subsequent issues to follow up on with regards to the way that the Cilium codebase relies on v4.9 to do testing. Those items are already listed in #22116 so we can continue to follow up on that over time. For now, we think it makes sense to nudge users onto newer kernel versions by documenting the higher minimum version, then over time we will actually remove support for older kernels.

@joestringer joestringer merged commit af9421f into cilium:master Jan 18, 2023
@joestringer joestringer deleted the submit/deprecate-v4.9 branch January 18, 2023 21:24
@aanm aanm mentioned this pull request Jan 23, 2023
19 tasks
@aanm aanm added backport-pending/1.13 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation notice for 4.9 kernel
7 participants
0