multicast: add CLIs to configure multicast bpf maps #31355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc987d3 to
0e61e9d
Compare
0e61e9d to
eff0644
Compare
|
/test |
nickolaev
approved these changes
Mar 13, 2024
eff0644 to
4d551a3
Compare
lambdanis
suggested changes
Mar 13, 2024
4d551a3 to
4758961
Compare
|
Thanks @lambdanis for the review. I fixed the rendering problem and example sections. Please have another look whenever you get a chance 🙏 Thank you @derailed, I addressed your comments as well. Thanks for the review 🙏 |
|
/test |
derailed
reviewed
Mar 15, 2024
9E88
4758961 to
a05dcf6
Compare
|
Thanks @derailed for detailed review 🙏 . I dry'd most of the repeatable code. There are couple of comments which I am not sure if I understand correctly. Pls have a look whenever you get a chance. |
a05dcf6 to
8ace2bb
Compare
|
/test |
This change adds cilium-dbg commands to manage multicast BPF maps. Following commands are added - cilium-dbg bpf multicast group list - cilium-dbg bpf multicast group add <group> - cilium-dbg bpf multicast group delete <group> - cilium-dbg bpf multicast subscriber list <group|all> - cilium-dbg bpf multicast subscriber add <group> <subscriber> - cilium-dbg bpf multicast subscriber delete <group> <subscriber> Signed-off-by: harsimran pabla <hpabla@isovalent.com>
8ace2bb to
86a3f2c
Compare
|
/test |
derailed
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
@harsimran-pabla just wanted to posting the information here.
with using Robot Operating System version 2 default transport layer is DDSI-RTPS (DDS-Interoperability Real Time Publish Subscribe) protocol well-known multicast group IP address is 239.255.0.1, i confirmed that application endpoint discovery and data communication just works out-of-the-box.
thanks!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This change adds cilium-dbg commands to manage multicast BPF maps.
Following commands are added
This is follow up of #29469
Feature tracking issue #13239
Enabling Multicast
Users can configure multicast maps sub-system to enable multicast connectivity in the cluster. Following configuration will be required to achieve this.
Enable multicast using cilium-cli
cilium config set multicast-enabled true-- This will result in cilium pod restart.
-- Cilium MUST be configured in vxlan tunnel mode.
For each cilium pod, configure desired multicast groups.
cilium-dbg multicast group add <group IP>Configure group subscriber map to add all nodes (except self) as remote subscribers.
cilium-dbg multicast subscriber add <groupIP> <SubscriberIP>-- Cilium node internal IP can be found using
kubectl get ciliumnodes.cilium.iocommand.-- Use internal IPs as subscriber IPs.
-- Omit self node IP from adding as subscriber.
After doing this, multicast receiver pods can send out IGMP join and multicast sender pods can start sending multicast stream.